chore(tracing): Use upstream OpenTelemetry for all tracing#4293
Draft
sfleen wants to merge 1 commit intosfleen/tracing-upstream-propagatorfrom
Draft
chore(tracing): Use upstream OpenTelemetry for all tracing#4293sfleen wants to merge 1 commit intosfleen/tracing-upstream-propagatorfrom
sfleen wants to merge 1 commit intosfleen/tracing-upstream-propagatorfrom
Conversation
sfleen
force-pushed
the
sfleen/tracing-upstream-processor
branch
from
5d0e3b2 to
cdbe533
Compare
sfleen
force-pushed
the
sfleen/tracing-upstream-propagator
branch
from
870d872 to
e460b63
Compare
sfleen
force-pushed
the
sfleen/tracing-upstream-processor
branch
2 times, most recently
from
4cb58f2 to
f2910f7
Compare
sfleen
force-pushed
the
sfleen/tracing-upstream-propagator
branch
from
e460b63 to
3d7b264
Compare
This removes all remaining bespoke tracing infrastructure. The main change here is registering a global tracer provider that the trace propagation service can use, replacing the manually wired span data channel. This leaves in some remnants of the old infrastructure, specifically around the span sink types. These types are fairly viral, so a future PR will clean these up. Signed-off-by: Scott Fleener <scott@buoyant.io>
sfleen
force-pushed
the
sfleen/tracing-upstream-processor
branch
from
f2910f7 to
3f9a2f9
Compare
unleashed
approved these changes
Nov 20, 2025
| .tracer | ||
| .span_builder("".to_string()) | ||
| .start_with_context(&self.tracer, &parent_ctx); | ||
| let tracer = opentelemetry::global::tracer(""); |
Member
There was a problem hiding this comment.
Did you consider caching this tracer in the context struct?
| task, | ||
| span_sink, | ||
| } | ||
| EnabledCollector { addr, span_sink } |
Member
There was a problem hiding this comment.
addr seems to no longer need to be cloned
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes all remaining bespoke tracing infrastructure. The main change here is registering a global tracer provider that the trace propagation service can use, replacing the manually wired span data channel.
This leaves in some remnants of the old infrastructure, specifically around the span sink types. These types are fairly viral, so a future PR will clean these up.